From: allfro <ndouba@gmail.com>
Date: Mon, 8 Apr 2013 01:22:16 +0000 (-0400)
Subject: Removed call to `execvp` with more portable `subprocess.Popen`
X-Git-Url: https://git.nothing2do.fr/?a=commitdiff_plain;h=4a089b44577d28ff89063d5f82a11e911e0ed8d0;p=get-hack-src.git

Removed call to `execvp` with more portable `subprocess.Popen`
---

diff --git a/src/canari/framework.py b/src/canari/framework.py
index e6602d0..e48dca8 100644
--- a/src/canari/framework.py
+++ b/src/canari/framework.py
@@ -4,8 +4,8 @@ from subprocess import PIPE, Popen
 from canari.resource import external_resource
 from canari.utils.stack import modulecallee
 
-from os import execvp, path
-from re import split
+import os
+import re
 
 
 __author__ = 'Nadeem Douba'
@@ -13,7 +13,7 @@ __copyright__ = 'Copyright 2012, Canari Project'
 __credits__ = []
 
 __license__ = 'GPL'
-__version__ = '0.2'
+__version__ = '0.3'
 __maintainer__ = 'Nadeem Douba'
 __email__ = 'ndouba@gmail.com'
 __status__ = 'Development'
@@ -65,7 +65,7 @@ class ExternalCommand(object):
         if interpreter is not None:
             self._extra_external_args.append(interpreter)
             libpath = external_resource(
-                path.dirname(transform_name),
+                os.path.dirname(transform_name),
                 '%s.resources.external' % modulecallee().__name__.split('.')[0]
             )
             if interpreter.startswith('perl') or interpreter.startswith('ruby'):
@@ -86,7 +86,7 @@ class ExternalCommand(object):
             )
 
         if isinstance(transform_args, basestring):
-            self._extra_external_args = split('\s+', transform_args)
+            self._extra_external_args = re.split('\s+', transform_args)
         else:
             self._extra_external_args.extend(transform_args)
 
@@ -100,4 +100,6 @@ class ExternalCommand(object):
             p = Popen(self._extra_external_args + list(args), stdin=PIPE, stdout=PIPE)
             out, err = p.communicate(request_xml)
             return out
-        execvp(self._extra_external_args[0], self._extra_external_args + list(args))
+        p = Popen(self._extra_external_args + list(args))
+        p.communicate()
+        exit(p.returncode)